Skip to content

Returning nic details in KubernetesClusterResponse#4456

Merged
DaanHoogland merged 1 commit intoapache:masterfrom
shapeblue:fix-cks-resp
Nov 11, 2020
Merged

Returning nic details in KubernetesClusterResponse#4456
DaanHoogland merged 1 commit intoapache:masterfrom
shapeblue:fix-cks-resp

Conversation

@davidjumani
Copy link
Contributor

@davidjumani davidjumani commented Nov 10, 2020 •
edited
Loading

Description

Adds nic details in KubernetesClusterResponse
Needed when the cluster is created on a shared network

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

(localcloud) SBCM5> > list kubernetesclusters 
{
  "count": 1,
  "kubernetescluster": [
    {
      "name": "k8sNew",
      .....
      "virtualmachines": [
        {
          "displayname": "k8sNew-master-175b10034fe",
          .....
          "nic": [
            {
              "broadcasturi": "vlan://7",
              "extradhcpoption": [],
              "gateway": "10.1.63.254",
              "id": "b400c7d3-0e92-4520-ad1f-2872553de4cc",
              "ipaddress": "10.1.39.61",
              "isdefault": true,
              "isolationuri": "vlan://7",
              "macaddress": "1e:00:18:00:00:29",
              "netmask": "255.255.224.0",
              "networkid": "6df796e2-57d5-4f14-8a66-e72b955ec749",
              "networkname": "sh",
              "secondaryip": [],
              "traffictype": "Guest",
              "type": "Shared"
            }
           .....
          ]
      ],
      "zoneid": "2a606f6d-d56e-47a5-9d6a-c432e7c972bf",
      "zonename": "ref-trl-1897-k-M7-david-jumani"
    }
  ]
}

@davidjumani
Copy link
Contributor Author

davidjumani commented Nov 10, 2020

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Nov 10, 2020

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Nov 10, 2020

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2348

shwstppr
shwstppr approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@PaulAngus PaulAngus added this to the 4.15.0.0 milestone Nov 10, 2020
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Nov 10, 2020

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Nov 10, 2020

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Nov 10, 2020

Trillian test result (tid-3138)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33906 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4456-t3138-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit 45f7b33 into apache:master Nov 11, 2020
@DaanHoogland DaanHoogland deleted the fix-cks-resp branch November 11, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

Severity:Major type:bug

Projects

None yet

Milestone

4.15.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@davidjumani @blueorangutan @DaanHoogland @shwstppr @PaulAngus